Ts simpler 2 #1134
Merged
Ts simpler 2 #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to Typescript (#1060) * Allow JS * Remove unused imports * Ignore Eslint config files in ESLint * Remove unused import from test/yup.js * Use instanceof instead of isSchema in prependDeep
jquense
commented
Dec 1, 2020
|
I ❤️ exclusiveTests. Thank you for making this public. |
|
it's not public! |
|
Ok, sshhh... it isn't public. ;-) |
gotexis
reviewed
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is what i've settled on, it's most similar to the DT types, and fairly verbose but not doing any weird typing things and most of the verbosity is in interfaces that will be compiled away.